Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] update cluster add-on link #49281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jan 3, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e7a390
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677867d67f273400082306a8
😎 Deploy Preview https://deploy-preview-49281--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/addon-manager/README.md is better?

$ curl -I https://releases.k8s.io/master/cluster/addons/addon-manager/README.md
HTTP/2 302 
server: nginx
date: Sat, 04 Jan 2025 16:54:51 GMT
content-type: text/html
content-length: 138
location: https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/addon-manager/README.md
via: 1.1 google
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

@Okabe-Junya
Copy link
Member

/assign sftim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants