Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Update resource-claim-v1beta1.md #49259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[zh] Update resource-claim-v1beta1.md #49259

wants to merge 1 commit into from
+1,969 −0

Conversation

windsonsea
Copy link
Member

Updated from v1alpha3 to v1beta1:

content/zh-cn/docs/reference/kubernetes-api/workload-resources/resource-claim-v1beta1.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from windsonsea. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 30, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3d22346
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/677235ee415fe6000863dc3c
😎 Deploy Preview https://deploy-preview-49259--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chenrui333
chenrui333 reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1798d3087b0529542b7318ec39815832402569aa

@windsonsea windsonsea mentioned this pull request Dec 31, 2024
Open
sftim
sftim reviewed Jan 2, 2025
View reviewed changes
content/zh-cn/docs/reference/kubernetes-api/workload-resources/resource-claim-v1beta1.md
Comment on lines +23 to +27
<!--
The file was copied and updated manually from the v1alpha3 API.
The content is not quite up-to-date, which needs to be fixed
by generating the file automatically.
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix the English original first? Usually that's the workflow we follow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems yes. It's a relatively complicated task to generate these reference. Need to wait for someone update them.

@sftim
Copy link
Contributor

sftim commented Jan 3, 2025

/hold
per #49259 (comment)

for a manual or automated update to the original (English) localization

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@chenrui333 chenrui333 chenrui333 left review comments

@Sea-n Sea-n Awaiting requested review from Sea-n

Assignees

@chenrui333 chenrui333

Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windsonsea @k8s-ci-robot @sftim @chenrui333