Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prow: cosi: add COSI Driver Sample and COSI monorepo config #34008

Merged
merged 3 commits into from
Jan 16, 2025
Merged

prow: cosi: add COSI Driver Sample and COSI monorepo config #34008

merged 3 commits into from
Jan 16, 2025

Conversation

shanduur
Copy link
Member

@shanduur shanduur commented Dec 19, 2024 •
edited
Loading

Adding configuration for COSI Driver Sample and COSI monorepo build/test process.

X-Ref: kubernetes-sigs/cosi-driver-sample#13

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs labels Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Dec 19, 2024
@shanduur shanduur changed the title prow: add COSI Driver Sample config prow: cosi: add COSI Driver Sample config Dec 19, 2024
@shanduur shanduur force-pushed the feat/add-cosi-sample-driver branch from 4e2a83d to 087aacf Compare December 19, 2024 09:41
@k8s-ci-robot k8s-ci-robot added area/testgrid size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2024
@shanduur shanduur changed the title prow: cosi: add COSI Driver Sample config prow: cosi: add COSI Driver Sample and COSI monorepo config Dec 19, 2024
@shanduur
Copy link
Member Author

@saad-ali @msau42 Could you please advise how to handle the retired repositories?

@shanduur
Copy link
Member Author

/assign @saad-ali
/assign @msau42

BlaineEXE
BlaineEXE reviewed Dec 19, 2024
View reviewed changes
...bernetes-sigs/container-object-storage-interface/container-object-storage-interface-api.yaml Outdated
@@ -1,3 +1,4 @@
# TODO(retired): should we drop this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From meeting today, we can drop references to old repos

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2024
@shanduur
feat: added missing COSI repos
9e1dd6f 
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur
chore: drop retired repos
95a2de5 
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur shanduur force-pushed the feat/add-cosi-sample-driver branch from 729ec8b to 95a2de5 Compare January 12, 2025 16:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2025
@saad-ali
Copy link
Member

Looks like some of the jobs are failing:

could not write config: 3 errors occurred:

  • could not find the referenced (Dashboard) sig-storage-container-object-storage-interface-api
  • could not find the referenced (Dashboard) sig-storage-container-object-storage-interface-controller
  • could not find the referenced (Dashboard) sig-storage-container-object-storage-interface-provisioner-sidecar
    FAIL k8s.io/test-infra/config/tests/testgrids 3.367s

CC @jsafrane @xing-yang

@shanduur shanduur force-pushed the feat/add-cosi-sample-driver branch from 996ba26 to 60835fb Compare January 15, 2025 14:48
@shanduur
Copy link
Member Author

shanduur commented Jan 15, 2025 •
edited
Loading

@saad-ali those are probably failing, because I removed the files (and added few new), cleaning those now.

  • sig-storage-container-object-storage-interface-api - retired project, now part of sig-storage-container-object-storage-interface
  • sig-storage-container-object-storage-interface-controller - retired project, now part of sig-storage-container-object-storage-interface
  • sig-storage-container-object-storage-interface-provisioner-sidecar - retired project, now part of sig-storage-container-object-storage-interface

@xing-yang
Copy link
Contributor

I see that the issue is fixed now.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@xing-yang
Copy link
Contributor

@saad-ali Can you please help approve this?

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, shanduur, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit fed003c into kubernetes:master Jan 16, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@shanduur: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key container-object-storage-interface-provisioner-sidecar.yaml using file ``
  • key container-object-storage-interface-api.yaml using file ``
  • key container-object-storage-interface.yaml using file config/jobs/kubernetes-sigs/container-object-storage-interface/container-object-storage-interface.yaml
  • key container-object-storage-interface-controller.yaml using file ``
  • key cosi-driver-sample.yaml using file config/jobs/kubernetes-sigs/container-object-storage-interface/cosi-driver-sample.yaml

In response to this:

Adding configuration for COSI Driver Sample and COSI monorepo build/test process.

X-Ref: kubernetes-sigs/cosi-driver-sample#13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE left review comments

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@xing-yang xing-yang

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shanduur @saad-ali @xing-yang @k8s-ci-robot @BlaineEXE @msau42