Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: pull-kubernetes-e2e-gci-gce-ingress run regex #33627

Merged

Conversation

aroradaman
Copy link
Member

@aroradaman aroradaman commented Oct 11, 2024

This adds pkg/proxy path to the trigger path for pull-kubernetes-e2e-gci-gce-ingress.
This could have detected ci failures in kubernetes/kubernetes#127794 before merge.

[EDIT]
This add pkg/proxy/healthcheck instead of pkg/proxy to the trigger path

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn October 11, 2024 07:26
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 11, 2024
@aroradaman
Copy link
Member Author

/cc @aojea @dims

@k8s-ci-robot k8s-ci-robot requested review from aojea and dims October 11, 2024 18:48
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 9, 2025
@aroradaman aroradaman force-pushed the pull-kubernetes-e2e-gci-gce-ingress branch from 77960d4 to d4c867a Compare January 20, 2025 19:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2025
@aroradaman
Copy link
Member Author

We can also consider pkg/proxy/healthcheck instead of pkg/proxy to reduce the number of invocations.

@aroradaman aroradaman force-pushed the pull-kubernetes-e2e-gci-gce-ingress branch from d4c867a to 1c2681a Compare January 20, 2025 19:24
@aojea
Copy link
Member

aojea commented Jan 20, 2025

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, aroradaman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 27da48c into kubernetes:master Jan 20, 2025
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aroradaman: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-gce.yaml using file config/jobs/kubernetes/sig-network/sig-network-gce.yaml

In response to this:

This adds pkg/proxy path to the trigger path for pull-kubernetes-e2e-gci-gce-ingress.
This could have detected ci failures in kubernetes/kubernetes#127794 before merge.

[EDIT]
This add pkg/proxy/healthcheck instead of pkg/proxy to the trigger path

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants