Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GCE backend service regional for the Terraform target #17229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tesspib
Copy link
Contributor

@tesspib tesspib commented Jan 22, 2025

kops' cloudup target for creating/updating a GCE cluster creates a regional backend service, which is on par with the forwarding rule being regional. The Terraform target however creates a global backend service and a regional forwarding rule, a combination that's not supported by GCP.
This PR aligns the Terraform target to the cloudup one and fixes the failing terraform apply.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman January 22, 2025 09:34
@k8s-ci-robot
Copy link
Contributor

Hi @tesspib. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from zetaab January 22, 2025 09:34
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Jan 22, 2025
@hakman
Copy link
Member

hakman commented Jan 22, 2025

/ok-to-test
/cc @justinsb
/assign @justinsb
/kind office-hours

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/office-hours labels Jan 22, 2025
@k8s-ci-robot k8s-ci-robot requested a review from justinsb January 22, 2025 09:52
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2025
@tesspib
Copy link
Contributor Author

tesspib commented Jan 22, 2025

This issue is also present in kops 1.29, which introduced internal load balancers, and imo the fix should be backported (provided it passes tests, of course)

@k8s-ci-robot
Copy link
Contributor

@tesspib: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test e4ca36c link true /test pull-kops-test
pull-kops-verify-terraform e4ca36c link true /test pull-kops-verify-terraform

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants