-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: use reconcile command for kOps 1.31+ #17152
base: master
Are you sure you want to change the base?
tests: use reconcile command for kOps 1.31+ #17152
Conversation
We expect people to start using the reconcile command particularly for upgrades.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"${KOPS_B}" update cluster --admin --yes | ||
# Verify no additional changes | ||
"${KOPS_B}" update cluster | ||
if [[ "${KOPS_VERSION_B}" =~ 1.3[123456789] ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should invert this, using the old method when the version matches 1.2
or 1.30
. That way we avoid surprises when 1.40 is tested.
/retest |
Are there any plans to document the reconcile command better and in more detail? As a kOps user, I do not quite understand the relation of this command especially to the "upgrade cluster" command. As far as I understand, it does something like "if a rolling-update is required after an update, perform a rolling update now", is this right? But when do you run the single "kops reconcile cluster" command instead of "kops update cluster --reconcile" ? |
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We expect people to start using the reconcile command
particularly for upgrades.