-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sig-cli CONTRIBUTING.md file #8225
Update sig-cli CONTRIBUTING.md file #8225
Conversation
Update the path to the implementation of kubectl
Welcome @mahdibouaziz! |
Hi @mahdibouaziz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I'm a little confused because both paths exist and reference information... |
@simonfogliato, from what I understand, the code in https://git.k8s.io/kubernetes/pkg/kubectl is outdated and no longer maintained. All the new kubectl code is now available at https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubectl/pkg. |
/ok-to-test |
@simonfogliato @mahdibouaziz to answer your previous questions, the https://git.k8s.io/kubernetes/pkg/kubectl contains ONLY the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mahdibouaziz, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Update the path to the implementation of kubectl to
kubernetes/staging/src/k8s.io/kubectl/pkg
insig-cli/CONTRIBUTING.md
Which issue(s) this PR fixes: #8224
Fixes #8224