Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sig-cli CONTRIBUTING.md file #8225

Merged

Conversation

mahdibouaziz
Copy link
Contributor

@mahdibouaziz mahdibouaziz commented Dec 26, 2024

Update the path to the implementation of kubectl to kubernetes/staging/src/k8s.io/kubectl/pkg in sig-cli/CONTRIBUTING.md

Which issue(s) this PR fixes: #8224

Fixes #8224

Update the path to the implementation of kubectl
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from soltysh December 26, 2024 19:12
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Dec 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @mahdibouaziz!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mahdibouaziz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@simonfogliato
Copy link

I'm a little confused because both paths exist and reference information...
https://git.k8s.io/kubernetes/pkg/kubectl
https://git.k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg
I think perhaps this PR change is not correct...

@mahdibouaziz
Copy link
Contributor Author

@simonfogliato, from what I understand, the code in https://git.k8s.io/kubernetes/pkg/kubectl is outdated and no longer maintained. All the new kubectl code is now available at https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubectl/pkg.
@mpuckett159 @soltysh @eddiezane , can you confirm ?

@soltysh
Copy link
Contributor

soltysh commented Jan 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2025
@soltysh
Copy link
Contributor

soltysh commented Jan 10, 2025

@simonfogliato @mahdibouaziz to answer your previous questions, the https://git.k8s.io/kubernetes/pkg/kubectl contains ONLY the kubectl-convert command, since that single command which was left in the main kubernetes repository requires internal types to properly convert between various versions. But since that's a separate binary it's perfectly fine to guide folks to https://git.k8s.io/kubernetes/staging/src/k8s.io/kubectl/pkg

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mahdibouaziz, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8a99192 into kubernetes:master Jan 10, 2025
3 checks passed
@simonfogliato
Copy link

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIG CLI: Update kubectl implementation path in CONTRIBUTING.md
4 participants