-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging on abandoning node scale down #7647
base: master
Are you sure you want to change the base?
Conversation
already logs information. - Change the abort node deletion to log a warning instead of an error if it happens that scheduler manages to put a pod on a node that is supposed to scale down. This is a known race condition that should not result in errors logged as they are misleading to oncallers (example: http://b/385203969#comment12)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jbtk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @jbtk! |
Hi @jbtk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind cleanup
What this PR does / why we need it:
Avoid double logging and log on appropriate severity
Does this PR introduce a user-facing change?
-->