Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pkg/jenkins): change the state update logic #354

Merged
merged 2 commits into from
Jan 24, 2025
Merged

refactor(pkg/jenkins): change the state update logic #354

merged 2 commits into from
Jan 24, 2025
+28 −18

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 7, 2025 •
edited
Loading

This can improved Jenkins type CI status display for better user experience.

  • Keep the prow job as triggered when the Jenkins build is still in queue.
  • Only set the prow job to pending state when the Jenkins build is running.

Previous Situation:

When a CI job was triggered, the status would show "Pending - Jenkins job enqueued" for running jobs, which could be misleading as it suggested the job hadn't started yet, and there are no links to view during the run.
image

This refactoring effect:

Running CI jobs now display "Pending - Jenkins job running" with detail url provided.
image

@wuhuizuo
refactor(pkg/jenkins): change the state update logic
05175c9 
- keep the prow job be `triggered` state until the jenkins build is running.
- only set the prow job be `pending` state when the jenkins build is running
  rather then the jenkins build enqueued.

Signed-off-by: wuhuizuo <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 31cd7b0
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/678dfafa0fdcbe0008272752
😎 Deploy Preview https://deploy-preview-354--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmguzik
Copy link
Contributor

jmguzik commented Jan 14, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2025
jmguzik
jmguzik approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@jmguzik jmguzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable change.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
@jmguzik
Copy link
Contributor

jmguzik commented Jan 24, 2025

Probably approver will ask you to squash commits so you may want to do that.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, petr-muller, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit d572f85 into kubernetes-sigs:main Jan 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmguzik jmguzik jmguzik approved these changes

@petr-muller petr-muller petr-muller approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@petr-muller petr-muller

@jmguzik jmguzik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuhuizuo @k8s-ci-robot @jmguzik @petr-muller