fix(dedup): records with different type are not duplicates

[jtszalay]

Description

RecordType is not included in deduplication key and therefore records with same name, setid, and targets but with different recordtype currently are treated as duplicates.

Fixes #4888

Checklist

• Unit tests updated
• End user documentation updated

^ I'm not sure of any documentation to update?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ✅login: jtszalay / (adb4a4f)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @jtszalay!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jtszalay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/ok-to-test
/retitle fix(dedup): records with different type are not duplicates

[simonoff]

Hi! If its ready then why it it waiting so logn for merge?

[ivankatliarchuk]

This is could be outsude of the scope of that pull request, but could we add a null check? The null check will help to avoid external-dns crashlooping. We could of course rely on providers, but just a safety check.

for _, ep := range endpoints {
  if ep == nill {
   continue
  }
}

[ivankatliarchuk]

Other options could be

identifier := strings.Join([]string{ep.DNSName, ep.SetIdentifier, ep.Targets.String()}, " / ")
or
identifier := fmt.Sprintf("%s / %s / %s", ep.DNSName, ep.SetIdentifier, ep.Targets.String())

Do we know why there are empty spaces " / "? Just a question?

[ivankatliarchuk]

What about case when one endpoint have no RecordType type and another one does?