add PreEvictionFilter extension to DefaultEvictor Plugin #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
knelasevero
commented
Sep 20, 2022
ingvagabund
requested changes
Sep 20, 2022
knelasevero
force-pushed
the
pre-ev-filter
branch
2 times, most recently
from
8fe6bf4 to
f68a1ac
Compare
k8s-ci-robot
added
size/XL
ingvagabund
reviewed
Sep 20, 2022
ingvagabund
requested changes
Sep 20, 2022
pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity.go
Outdated
Show resolved
Hide resolved
knelasevero
force-pushed
the
pre-ev-filter
branch
from
f68a1ac to
edec8fe
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #640 (comment) I am just moving nodefit check to the preEvictionFilter extension point of the DefaultEvictor plugin. Follow ups would include those other options of that issue (and namespace selectors, etc).
Let me know if the evocation of the extension point shouldn't be done in the way that I did.
Also related to #924, #753 (comment),