-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨feat: add GoCollector and ProcessCollector metrics #3070
base: main
Are you sure you want to change the base?
✨feat: add GoCollector and ProcessCollector metrics #3070
Conversation
Signed-off-by: dongjiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/metrics/registry.go
Outdated
collectors.GoRuntimeMetricsRule{Matcher: regexp.MustCompile(`^/sync/.*`)}, | ||
), | ||
), | ||
collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}), |
We do this in pkg/internal/controller/metrics/metrics.go
, do we need to do this here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @troy0820 Please re-check
Move to pkg/internal/controller/metrics
better.
Fixed.
Signed-off-by: dongjiang <[email protected]>
Default add GoCollector and ProcessCollector metrics for controller-runtime metrics package