✨Replace k8s.io/utils/pointer with k8s.io/utils/ptr #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
inteon
force-pushed
the
upgrade_dependencies
branch
3 times, most recently
from
4b37446 to
089c43a
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
inteon
force-pushed
the
upgrade_dependencies
branch
from
089c43a to
f31d88e
Compare
k8s-ci-robot
added
size/L
inteon
force-pushed
the
upgrade_dependencies
branch
from
f31d88e to
3b8c36e
Compare
inteon
changed the title
Signed-off-by: Tim Ramlot <[email protected]>
k8s-ci-robot
removed
the
needs-rebase
inteon
force-pushed
the
upgrade_dependencies
branch
from
3b8c36e to
3ddde48
Compare
|
@vincepri I re-scoped this PR, it should be ready to be merged. |
alvaroaleman
approved these changes
Nov 21, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced k8s.io/utils/pointer with k8s.io/utils/ptr to fix the golint deprecation errors