🐛 Check to see if custom source implements fmt.Stringer when logging (#…

…3068) * add String() to source interface Signed-off-by: Troy Connor <[email protected]> * remove the enforcement of fmt.Stringer --------- Signed-off-by: Troy Connor <[email protected]>
kubernetes-sigs · Jan 19, 2025 · aafb269 · aafb269
1 parent 8f7e114
commit aafb269
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/pkg/internal/controller/controller.go b/pkg/internal/controller/controller.go
@@ -175,7 +175,16 @@ func (c *Controller[request]) Start(ctx context.Context) error {
 		// caches.
 		errGroup := &errgroup.Group{}
 		for _, watch := range c.startWatches {
-			log := c.LogConstructor(nil).WithValues("source", fmt.Sprintf("%s", watch))
+			log := c.LogConstructor(nil)
+			_, ok := watch.(interface {
+				String() string
+			})
+
+			if !ok {
+				log = log.WithValues("source", fmt.Sprintf("%T", watch))
+			} else {
+				log = log.WithValues("source", fmt.Sprintf("%s", watch))
+			}
 			didStartSyncingSource := &atomic.Bool{}
 			errGroup.Go(func() error {
 				// Use a timeout for starting and syncing the source to avoid silently