🌱 Update golangci-lint to v1.63.4 #11740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpecations If we don't do this, it converts the line to expect the count value equal to 1, which changes the semantics of the test
k8s-ci-robot
added
cncf-cla: yes
|
CC @sbueringer I've split out the v1.63.4 upgrade here and solved the new complaints from the upgrade, if we merge this I can rebase my other PR and focus just on the API linting |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8f08cf7ca32b6642f4c15c8623c9f79b71e0114b
|
|
/area ci |
k8s-ci-robot
added
area/ci
|
Thank you! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates
golangci-lintto the latest release and runsmake lint-fixto fix up any issues that it found post update.Some of the issues it came up with were odd, eg suggesting
Instead of
Which are not semantically equivalent.
These cases I fixed in a different way.
Some of the fixes that were being applied also removed a whole load of comments, so I didn't commit those, and
make lint-fixno longer suggests removing those. One of the linters suggested fixes does not appear to be deterministic, sigh.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #