Skip to content
PR golangci-lint

🌱 DNM: Add KAL linter for linting API conventions #7217

Sign in to view logs

🌱 DNM: Add KAL linter for linting API conventions

🌱 DNM: Add KAL linter for linting API conventions #7217

Triggered via pull request January 22, 2025 13:11
@JoelSpeedJoelSpeed
opened #11733
JoelSpeed:add-api-linter
Status Failure
Total duration 5m 9s
Artifacts –

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

30 errors and 3 warnings
lint (test): exp/api/v1beta1/machinepool_types.go#L133
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test): exp/api/v1beta1/machinepool_types.go#L150
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (test): controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L339
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test): controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L360
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (test): exp/ipam/api/v1beta1/ipaddressclaim_types.go#L44
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test): api/v1beta1/cluster_types.go#L903
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test): api/v1beta1/cluster_types.go#L925
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (test): api/v1beta1/clusterclass_types.go#L978
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test): api/v1beta1/clusterclass_types.go#L998
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (test): api/v1beta1/machine_types.go#L564
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): exp/api/v1beta1/machinepool_types.go#L133
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): exp/api/v1beta1/machinepool_types.go#L150
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (hack/tools): controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L339
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L360
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (hack/tools): exp/ipam/api/v1beta1/ipaddressclaim_types.go#L44
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): api/v1beta1/cluster_types.go#L903
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): api/v1beta1/cluster_types.go#L925
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (hack/tools): api/v1beta1/clusterclass_types.go#L978
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (hack/tools): api/v1beta1/clusterclass_types.go#L998
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint (hack/tools): api/v1beta1/machine_types.go#L564
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: exp/api/v1beta1/machinepool_types.go#L133
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: exp/api/v1beta1/machinepool_types.go#L150
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint: controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L339
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go#L360
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint: exp/ipam/api/v1beta1/ipaddressclaim_types.go#L44
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: api/v1beta1/cluster_types.go#L903
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: api/v1beta1/cluster_types.go#L925
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint: api/v1beta1/clusterclass_types.go#L978
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint: api/v1beta1/clusterclass_types.go#L998
conditions: Conditions field is missing the following markers: patchStrategy=merge, patchMergeKey=type (kal)
lint: api/v1beta1/machine_types.go#L564
conditions: Conditions field must be a slice of metav1.Condition (kal)
lint (test)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint (hack/tools)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636