-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean aks-as-mgmt.sh and Tiltfile #5385
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5385 +/- ##
=======================================
Coverage 52.43% 52.44%
=======================================
Files 272 272
Lines 29349 29349
=======================================
+ Hits 15389 15391 +2
+ Misses 13154 13152 -2
Partials 806 806 ☔ View full report in Codecov by Sentry. |
Tested these changes locally and was able to delete Peerings
|
f564e05
to
03e620b
Compare
aks-as-mgmt.sh - Remove unused variables - Rearrange the printing of the variables - update K8s to v1.30.2 Tiltfile - Delete peering command is using /bin/sh -e, hence ${PEERING_NAMES[@]} gives error. Replacing ${PEERING_NAMES[@]} with ${PEERING_NAMES}
03e620b
to
9617982
Compare
/retest |
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 676528961c498a8fb365882967e05c26d83e2cfb
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
v1.30.2
aks-as-mgmt.sh
script by dropping unused ENV Vars./bin/sh
to process peering_namesfor PEERING_NAME in ${PEERING_NAMES} ...
./bin/sh
fails withbad substitution
when it encounters${PEERING_NAME[@]}
. Hence it has been replaced with${PEERING_NAME}
.${PEERING_NAME[@]}
is applicable when using/bin/bash
to run the commands.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
TODOs:
Release note: