Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of AKS-as-mgmt nodepools to 2 and max pods per nodepool to 60 #5383

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jan 23, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Increases the total number of nodepools of "AKS as mgmt cluster" to 2.
  • Also increases the total number of schedule able nodes to 60 from (default) 30.
  • Without this change, CAPZ pods from Tilt would not get scheduled on AKS-as-mgmt cluster because Tilt had already deployed 30 pods.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@nawazkh nawazkh changed the title Increase number of AKS nodes to 2 and quadraple the max nodes that can be scheduled Increase number of AKS-as-mgmt nodes to 2 and max pods per nodepool to 60 Jan 23, 2025
@nawazkh nawazkh changed the title Increase number of AKS-as-mgmt nodes to 2 and max pods per nodepool to 60 Increase number of AKS-as-mgmt nodepools to 2 and max pods per nodepool to 60 Jan 23, 2025
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0782ce722c77e8cdfba023459902e7a530387b2a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (8b8ba05) to head (1e115e2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5383      +/-   ##
==========================================
- Coverage   52.44%   52.43%   -0.01%     
==========================================
  Files         272      272              
  Lines       29349    29349              
==========================================
- Hits        15391    15389       -2     
- Misses      13152    13154       +2     
  Partials      806      806              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh nawazkh merged commit 90b15c2 into kubernetes-sigs:main Jan 23, 2025
29 of 39 checks passed
@nawazkh nawazkh deleted the update_aks_mgmt_capacity branch January 23, 2025 00:43
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants