-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4 #4577
dependabot(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4 #4577
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
=======================================
Coverage 62.46% 62.46%
=======================================
Files 192 192
Lines 15394 15394
=======================================
Hits 9616 9616
Misses 5118 5118
Partials 660 660 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks like codecov is failing this for the security alert that it tries to fix?
LGTM label has been added. Git tree hash: 5c4b99528874665dee61d347ff34ffa6abf8fad1
|
It's odd to me that the dependency review thing is flagging the version this PR is updating to, but the security advisory says version 41+ is fixed, which this is. And the security advisory was first published almost 2 months ago. I'll try re-running the job just to see... |
Looks like re-running it didn't help. Maybe try again after #4578 merges? |
@dependabot rebase |
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42.0.2 to 42.0.4. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@90a06d6...3f54ebb) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
9cbced9
to
e4fa151
Compare
/lgtm |
LGTM label has been added. Git tree hash: 6f1bdbd43719662065d77e2253ee8200338bb4fc
|
Dependency Review seems to be flagging this dep but somehow is not aware of the version.
Notice that the line I am not sure.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/override "Dependency Review"
@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override dependency-review |
@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is a newer version of the dependency-review GH action available, but I can't tell if it fixes this specific problem. Maybe we should wait until Monday when dependabot should create that dependency-review PR, and then we can see. |
Not sure why that works but it seems like it does: #4594. I'll update this PR now instead of waiting in case our 5/week cap doesn't happen to include the next bump. I'll close #4594 if this passes CI after updating it just so it's easier to track this down later if we filter on dependabot PRs. |
I keep getting these PRs mixed up lol. #4594 actually still fails when both changed-files and dependency-review are updated. I'm thinking we should just close this since the only material change this is making is turning CI red. Then hopefully down the road dependabot will bring us a fix. |
/close |
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps tj-actions/changed-files from 42.0.2 to 42.0.4.
Release notes
Sourced from tj-actions/changed-files's releases.
... (truncated)
Changelog
Sourced from tj-actions/changed-files's changelog.
... (truncated)
Commits
3f54ebb
chore: update formatting and add missing dist changes (#1940)6f070cf
Upgraded to v42.0.3 (#1939)ec75ae5
Updated README.md (#1938)4333ab5
docs: add codesculpture as a contributor for code, and bug (#1937)e3cac49
fix(payload_api, git_diff): Accessing correct property in payload and Replaci...68bd453
chore(deps): update github artifact actions to v4 (major) (#1936)f0ce41b
chore(deps): update dependency eslint-plugin-jest to v27.9.0ce451bf
chore(deps): update dependency@types/node
to v20.11.197592e9e
chore(deps): update dependency@types/node
to v20.11.18999653c
chore(deps): lock file maintenanceDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)