Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot(deps): bump tj-actions/changed-files from 42.0.2 to 42.0.4 #4577

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 19, 2024

Bumps tj-actions/changed-files from 42.0.2 to 42.0.4.

Release notes

Sourced from tj-actions/changed-files's releases.

v42.0.4

What's Changed

Full Changelog: tj-actions/changed-files@v42...v42.0.4

v42.0.3

What's Changed

... (truncated)

Changelog

Sourced from tj-actions/changed-files's changelog.

Changelog

42.0.4 - (2024-02-18)

⚙️ Miscellaneous Tasks

  • Update formatting and add missing dist changes (#1940) (3f54ebb) - (Tonye Jack)

⬆️ Upgrades

  • Upgraded to v42.0.3 (#1939)

Co-authored-by: jackton1 [email protected] Co-authored-by: GitHub Action [email protected] (6f070cf) - (tj-actions[bot])

42.0.3 - (2024-02-17)

🐛 Bug Fixes

  • payload_api, git_diff: Accessing correct property in payload and Replacing --quiet with --no-patch in git diff (#1934) (e3cac49) - (Aravind)
  • Broken link to matrix example workflow (#1918) (ea35f7e) - (KeisukeYamashita)

➕ Add

  • Added missing changes and modified dist assets. (07ac0ac) - (GitHub Action)

🔄 Update

  • Updated README.md (#1938)

Co-authored-by: jackton1 [email protected] (ec75ae5) - (tj-actions[bot])

  • Update README.md (8eced8a) - (Tonye Jack)
  • Update README.md (b2d4e1b) - (Tonye Jack)
  • Updated README.md (#1920)

Co-authored-by: jackton1 [email protected] (3399f88) - (tj-actions[bot])

  • Updated README.md (#1917)

Co-authored-by: jackton1 [email protected] (8e56bc0) - (tj-actions[bot])

  • Update action.yml (f6d3fe5) - (Tonye Jack)
  • Update README.md (efa99ea) - (Tonye Jack)
  • Update README.md (6d8f9bd) - (Tonye Jack)
  • Updated README.md (#1915)

Co-authored-by: jackton1 [email protected] (7daee9e) - (tj-actions[bot])

  • Update README.md (99c80bd) - (Tonye Jack)
  • Updated README.md (#1911)

Co-authored-by: jackton1 [email protected] (aa31060) - (tj-actions[bot])

... (truncated)

Commits
  • 3f54ebb chore: update formatting and add missing dist changes (#1940)
  • 6f070cf Upgraded to v42.0.3 (#1939)
  • ec75ae5 Updated README.md (#1938)
  • 4333ab5 docs: add codesculpture as a contributor for code, and bug (#1937)
  • e3cac49 fix(payload_api, git_diff): Accessing correct property in payload and Replaci...
  • 68bd453 chore(deps): update github artifact actions to v4 (major) (#1936)
  • f0ce41b chore(deps): update dependency eslint-plugin-jest to v27.9.0
  • ce451bf chore(deps): update dependency @​types/node to v20.11.19
  • 7592e9e chore(deps): update dependency @​types/node to v20.11.18
  • 999653c chore(deps): lock file maintenance
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f477b51) 62.46% compared to head (e4fa151) 62.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4577   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files         192      192           
  Lines       15394    15394           
=======================================
  Hits         9616     9616           
  Misses       5118     5118           
  Partials      660      660           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks like codecov is failing this for the security alert that it tries to fix?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c4b99528874665dee61d347ff34ffa6abf8fad1

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 20, 2024

/lgtm

Looks like codecov is failing this for the security alert that it tries to fix?

It's odd to me that the dependency review thing is flagging the version this PR is updating to, but the security advisory says version 41+ is fixed, which this is. And the security advisory was first published almost 2 months ago. I'll try re-running the job just to see...

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 20, 2024

Looks like re-running it didn't help. Maybe try again after #4578 merges?

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 20, 2024

@dependabot rebase

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42.0.2 to 42.0.4.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@90a06d6...3f54ebb)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/tj-actions/changed-files-42.0.4 branch from 9cbced9 to e4fa151 Compare February 20, 2024 16:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@nawazkh
Copy link
Member

nawazkh commented Feb 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f1bdbd43719662065d77e2253ee8200338bb4fc

@nawazkh
Copy link
Member

nawazkh commented Feb 20, 2024

Dependency Review seems to be flagging this dep but somehow is not aware of the version.

Dependency review did not detect any denied packages
Vulnerabilities
  .github/workflows/release.yaml » tj-actions/changed-files@3f54ebb830831fc121d3263c1857cfbdc310cdb9 – tj-actions/changed-files has Potential Actions command injection in output filenames (GHSL-2023-271) (high severity)
    ↪ https://github.com/advisories/GHSA-mcph-m25j-8j63
  Error: Dependency review detected vulnerable packages.

Notice that the line tj-actions/changed-files has Potential Actions command injection in output filenames (GHSL-2023-271) <- doesn't point to the version of tj-actions/changed-files.
Could it be that the Dependency Review is unable to see the version and just flagging the dependency -> "hey user, this dep is vulnerable, check out the GHSL-2023-271"?

I am not sure..

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/override "Dependency Review"

@k8s-ci-robot
Copy link
Contributor

@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Dependency Review

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • deploy/netlify
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/approve
/override "Dependency Review"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@mboersma
Copy link
Contributor

/override dependency-review

@k8s-ci-robot
Copy link
Contributor

@mboersma: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • dependency-review

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • deploy/netlify
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override dependency-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

mboersma commented Feb 22, 2024

There is a newer version of the dependency-review GH action available, but I can't tell if it fixes this specific problem.

Maybe we should wait until Monday when dependabot should create that dependency-review PR, and then we can see.

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 23, 2024

There is a newer version of the dependency-review GH action available, but I can't tell if it fixes this specific problem.

Maybe we should wait until Monday when dependabot should create that dependency-review PR, and then we can see.

Not sure why that works but it seems like it does: #4594. I'll update this PR now instead of waiting in case our 5/week cap doesn't happen to include the next bump. I'll close #4594 if this passes CI after updating it just so it's easier to track this down later if we filter on dependabot PRs.

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 23, 2024

I keep getting these PRs mixed up lol. #4594 actually still fails when both changed-files and dependency-review are updated. I'm thinking we should just close this since the only material change this is making is turning CI red. Then hopefully down the road dependabot will bring us a fix.

@mboersma
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/tj-actions/changed-files-42.0.4 branch February 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants