-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add UT for ListenEndpoint in utils.go #2339
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request includes changes to the
pkg/csi-common/utils.go
andpkg/csi-common/utils_test.go
files to improve error handling and add new tests for theListenEndpoint
function. The most important changes include refactoring the logging mechanism and adding a comprehensive test for theListenEndpoint
function.Improvements to error handling:
pkg/csi-common/utils.go
: Introduced a newklogFatalf
function to replace direct calls toklog.Fatalf
, allowing for better control and testing of fatal log messages.Enhancements to testing:
pkg/csi-common/utils_test.go
: Added a newTestListenEndpoint
function to test various scenarios for theListenEndpoint
function, including handling of Unix and TCP sockets, and invalid endpoints. This function also skips tests on Windows and uses a mockklogFatalf
to prevent actual termination during tests.pkg/csi-common/utils_test.go
: Updated imports to includeos
andruntime
packages, which are required for the new tests.<!-- Thanks for sending a pull request! Here are some tips for you:https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: