-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: GetRemoteServerFromTarget on Windows cache optimization #2185
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fd614f1
to
bde10b8
Compare
bde10b8
to
1d91000
Compare
/retest |
2 similar comments
/retest |
/retest |
@andyzhangx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick release-1.31 |
/cherrypick release-1.30 |
@andyzhangx: new pull request created: #2188 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@andyzhangx: new pull request created: #2189 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
revert: GetRemoteServerFromTarget on Windows cache optimization
this PR is a revert of #1934 since finally we have replaced
(Get-Item -Path $Env:mount).Target
with golang APIos.Readlink
in #2172, that would solve the performance issueWhich issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: