Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped to [email protected] and generated files #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holgerson97
Copy link
Contributor

@holgerson97 holgerson97 commented Oct 12, 2024

#16

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2024
@skitt
Copy link
Member

skitt commented Nov 21, 2024

Could you squash your commits please?

@holgerson97 holgerson97 force-pushed the chore/kustomize_version_bump branch from 6944315 to f4bff22 Compare November 23, 2024 10:52
@holgerson97
Copy link
Contributor Author

Could you squash your commits please?

Done.

@skitt
Copy link
Member

skitt commented Nov 25, 2024

/approve

@lauralorenz could you review this?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97, skitt
Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -10,7 +10,7 @@ spec:
spec:
containers:
- name: kube-rbac-proxy
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0/kubebuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a typo no?

Suggested change
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0/kubebuilder
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0

@lauralorenz
Copy link
Contributor

If you can confirm on #25 (review), I'm going to approve this and the other version bump PRs, but overall we do need these files to be unravelled up to root so it's less confusing with that loose root /go.mod and such per #28. I realize now that you might have been waiting for these to be approved first though so I'll do that 😇

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants