-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped to [email protected] and generated files #25
base: master
Are you sure you want to change the base?
Bumped to [email protected] and generated files #25
Conversation
Could you squash your commits please? |
6944315
to
f4bff22
Compare
Done. |
/approve @lauralorenz could you review this? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: holgerson97, skitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -10,7 +10,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: kube-rbac-proxy | |||
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0 | |||
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0/kubebuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a typo no?
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0/kubebuilder | |
image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0 |
If you can confirm on #25 (review), I'm going to approve this and the other version bump PRs, but overall we do need these files to be unravelled up to root so it's less confusing with that loose root |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
#16