Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kustomize patchesStrategicMerge deprecation warning #2405

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix Kustomize patchesStrategicMerge deprecation warning #2405

merged 1 commit into from
Jan 28, 2025

Conversation

astefanutti
Copy link
Contributor

What this PR does / why we need it:

A follow up of #2388 to fix the following warning when installing the v2 operator:

# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Fixed fields:
  patchesJson6902 -> patches
  patchesStrategicMerge -> patches
  commonLabels -> labels

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jan 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13008401315

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 12987312015: 0.0%
Covered Lines: 85
Relevant Lines: 85
💛 - Coveralls

tenzen-y
tenzen-y reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

manifests/v2/third-party/jobset/kustomization.yaml
- patches/jobset_config_patch.yaml # Add custom manager config to the JobSet.
patches:
# Remove namespace from the JobSet release manifests.
- path: patches/jobset_remove_namespace.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- path: patches/jobset_remove_namespace.yaml
- path: patches/jobset_remove_namespace.yaml
target:
group: xx
version: yy
kind: zz

Could we specify the target GVK to make the patch more declaratively?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leaned on the minimal fix, but I agree that'd be better with a target specified. I'm on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jan 28, 2025
@tenzen-y
Copy link
Member

/rerun-all

tenzen-y
tenzen-y reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 28, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/rerun-all

1 similar comment
@andreyvelich
Copy link
Member

/rerun-all

@google-oss-prow google-oss-prow bot merged commit 7ed7368 into kubeflow:master Jan 28, 2025
54 of 56 checks passed
oferla pushed a commit to run-ai/training-operator that referenced this pull request Feb 4, 2025
@astefanutti @ronk21runai
Fix Kustomize patchesStrategicMerge deprecation warning (kubeflow#2405)
cffd2a1 
Signed-off-by: Antonin Stefanutti <[email protected]>
Signed-off-by: R.K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astefanutti @coveralls @tenzen-y @andreyvelich