Skip to content

Commit

Permalink
Update manifest: make namespace configurable
Browse files Browse the repository at this point in the history
Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>
  • Loading branch information
Xinmin Du authored and Doris-xm committed Jan 13, 2025
1 parent 1100986 commit a038ef2
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions manifests/v2/base/manager/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
resources:
- manager.yaml
# TODO (andreyvelich): Move it to overlays once we copy the JobSet manifests.
namespace: kubeflow-system
2 changes: 0 additions & 2 deletions manifests/v2/base/rbac/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ resources:
- role.yaml
- role_binding.yaml
- service_account.yaml
# TODO (andreyvelich): Move it to overlays once we copy the JobSet manifests.
namespace: kubeflow-system
2 changes: 0 additions & 2 deletions manifests/v2/base/webhook/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ patches:
kind: ValidatingWebhookConfiguration
configurations:
- kustomizeconfig.yaml
# TODO (andreyvelich): Move it to overlays once we copy the JobSet manifests.
namespace: kubeflow-system
4 changes: 2 additions & 2 deletions manifests/v2/overlays/kubeflow-platform/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ resources:
- ../../base/webhook
- ../../base/runtimes/pre-training
- kubeflow-training-roles.yaml
# TODO (andreyvelich): JobSet should support kubeflow-system namespace.
# TODO (andreyvelich): JobSet should support kubeflow namespace.
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.6.0/manifests.yaml
images:
- name: kubeflow/training-operator-v2
newTag: latest
secretGenerator:
- name: training-operator-v2-webhook-cert
namespace: kubeflow-system
namespace: kubeflow
options:
disableNameSuffixHash: true

0 comments on commit a038ef2

Please sign in to comment.