Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on k8s.io/kubernetes #2398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobsalway
Copy link
Member

Purpose of this PR

  • Remove dependency on k8s.io/kubernetes by bringing the interrupt handler structure into the repo.
  • k8s.io/kubernretes is not intended to be used by any external projects, causes headaches when trying to upgrade k8s.io dependencies and requires replace directives in the go.mod.

kubernetes/kubernetes#79384

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway
Copy link
Member Author

/assign @ImpSy @ChenYi015

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ImpSy
Once this PR has been reviewed and has the lgtm label, please ask for approval from chenyi015. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ImpSy
Copy link
Contributor

ImpSy commented Jan 22, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants