Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Doris-xm as a member #733

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Doris-xm
Copy link
Contributor

Links to PRS:

Output of pytest:

$ pytest test_org_yaml.py
====================================================================== test session starts =======================================================================
platform darwin -- Python 3.10.9, pytest-7.1.2, pluggy-1.0.0
rootdir: /Users/dxm/Project/kubeflow/internal-acls/github-orgs
plugins: anyio-3.5.0
collected 1 item                                                                                                                                                 

test_org_yaml.py .                                                                                                                                         [100%]

======================================================================= 1 passed in 0.12s ========================================================================

List 2 existing members who are sponsoring your membership:
@Electronic-Waste @tenzen-y
PTAL, thx!

Signed-off-by: Xinmin Du <[email protected]>
Copy link

Hi @Doris-xm. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Electronic-Waste
Copy link
Member

Greatly deserved! I'm happy to sponsor this request and looking forward to working with you in the future! 🎉

/ok-to-test
/lgtm
/assign @kubeflow/wg-automl-leads

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @Doris-xm and welcome to Kubeflow Community 🎉
/lgtm
/assign @tenzen-y @johnugeorge

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

@andreyvelich
Copy link
Member

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c1ae315 into kubeflow:master Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants