fix(validation-reconciler): correct output and flow status report #1920
+58
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
force-pushed
the
fix/output-flow-status
branch
from
c24a595 to
83b8e20
Compare
pepov
reviewed
Jan 23, 2025
csatib02
force-pushed
the
fix/output-flow-status
branch
4 times, most recently
from
c159a1e to
f99ad35
Compare
pepov
approved these changes
Jan 26, 2025
| @@ -10,7 +10,7 @@ LoggingSpec defines the desired state of Logging | |||
|
|
|||
| ### allowClusterResourcesFromAllNamespaces (bool, optional) {#loggingspec-allowclusterresourcesfromallnamespaces} | |||
|
|
|||
| Allow configuration of cluster resources from any namespace. Mutually exclusive with ControlNamespace restriction of Cluster resources | |||
| Allow configuration of cluster resources from any namespace. Mutually exclusive with ControlNamespace restriction of Cluster resources WARNING: Becareful when turning this on and off as it can result in some resources being orphaned. | |||
There was a problem hiding this comment.
Is this still valid with the immutable constraint being present?
There was a problem hiding this comment.
If a cluster output gets selected by a single logging, because of this flag being turned on, then its status will be filled out. If we turn this off the cluster output will not be selected, but its status will indicate that it is still active. So yeah users can make resources stuck if they turn this on and off.
Signed-off-by: Bence Csati <[email protected]>
csatib02
force-pushed
the
fix/output-flow-status
branch
from
f99ad35 to
3ca364b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1140
Fixes: #700