KTOR-7832 Rewrite client-mpp sample to fix build errors #211
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| android { | ||
| compileSdk = 34 |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| @@ -0,0 +1,5 @@ | |||
| package io.ktor.samples.mpp.client | |||
Check warning
Code scanning / detekt
Checks whether files end with a line separator. Warning
| @@ -0,0 +1,5 @@ | |||
| package io.ktor.samples.mpp.client | |||
|
|
|||
| import kotlinx.coroutines.* | |||
Check warning
Code scanning / detekt
Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning
|
Latest build is successful :) But I couldn't figure out what should be changed in order to open "preview" in xCode |
|
Also I should mention, URL we try to fetch in this sample always returns the same html <html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>503 Server Error</title>
</head>
<body text="#000000" bgcolor="#ffffff">
<h1>Error: Server Error</h1>
<h2>The service you requested is not available yet.<p>Please try again in 30 seconds.</p></h2>
<h2></h2>
</body></html>Maybe we should change it to https://example.org? |
|
@stokado, yep. Let's change. |
Summary
This PR aims to fix failing builds of the client-mpp sample.
Approach
YouTrack Ticket