Change field delimiter in data directory from semicolon to comma #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIA_Annotations.csv is now the same as ISCN3Annoations.csv Trivial, but using commas means GH can render the table in browser and we don't have to play guess-the-delimeter when dealing with annotation tables.
|
updated selfDocumentAnnotations.csv and templateAnnotations.csv with subsequent edits (see above) |
brandonnodnarb
added a commit
that referenced
this pull request
Sep 26, 2024
…otations.csv Trivial, but now ISCN3Annotations.csv have the same delimeter as all other files in data directory. If agree, either accept this change OR PR #53 to make delimeters consistent. DO NOT ACCEPT BOTH OR WE WILL HAVE THE SAME "PROBLEM" IN REVERSE :)
|
GH will render the table but R-package will auto load ';' delims. This is actually a tradeoff that deserves discussion so I'm not approving this pull request yet. |
|
Ah, gotcha. I don't mind if it renders in GH. I mean, it's nice but not needed by any stretch. As per your comment
I did wonder about that. It's why I created PR #54. :) |
|
On further reflection we don't have the package build actually working yet. When we do we can look at switching it back if needed. This would make it easier to communicate what these tables cover if they were rendered by GH automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIA_Annotations.csv is now the same as ISCN3Annoations.csv
Trivial, but using commas means GH can render the table in browser and we don't have to play guess-the-delimeter when dealing with annotation tables.