Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to save and load timeslider bookmarks on the timeline to Studio Library #454

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TAbramsDG
Copy link

At the studio I work for, we had a special need to save and load bookmarks alongside our animations in studio library, this branch adds that functionality by using mutlis' meta data saving system. It adds a new key value pair in the meta data for a list of bookmarks that is then loaded when an animation is brought in. The data inside of the meta data is formatted in one long string containing the name of the bookmark, the start frame, the stop frame, and the color. Comments are included in the code that outline how that string is formatted.

Wanted to request a pull into the main branch, should you want to include this feature, in the hopes that we might be able to continue to receive new updates without backporting this feature but if not I do understand considering this is a pretty specific feature. Please let me know if there's any formatting or structural changes that would have to happen.

Thank you in advance, and have a great day!

@thoolaeff
Copy link

oh this is actually interesting to me as we are using bookmarks (although animbot bookmarks) to record clip names and durations on our timelines to feed into our exporter. I'm curious if you have made functionality to be able to export a string of bookmarks from the timeline into studio library? If you could choose to create anim or pose I could imagine processing a timeline of bookmarked face shapes or hand poses into studio library in a single click... would be pretty great.

@TAbramsDG
Copy link
Author

oh this is actually interesting to me as we are using bookmarks (although animbot bookmarks) to record clip names and durations on our timelines to feed into our exporter. I'm curious if you have made functionality to be able to export a string of bookmarks from the timeline into studio library? If you could choose to create anim or pose I could imagine processing a timeline of bookmarked face shapes or hand poses into studio library in a single click... would be pretty great.

Hey! Yup! It works by gathering all bookmarks in your timeline (I believe within your saving range but I have to double check) and stores them in a list of strings that have all of the data encoded inside each string element, when the animation is loaded it reconstructs those bookmarks onto the timeline by reading that string and parsing out the data

It does not currently work with poses however, only timeline animations

Also it assumes youre using the timesliderbookmark plugin, not sure if thats the one anim bot is using

@TAbramsDG
Copy link
Author

I noticed a bug where I think the animations arent loading entirely correctly, need to look into that, I think the bookmark creation messes with the keyframe time

@TAbramsDG TAbramsDG closed this Mar 22, 2024
@TAbramsDG
Copy link
Author

Fixed bugs and verified animations are saving and loading correctly

@TAbramsDG TAbramsDG reopened this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants