fix(check-plugin): format output for indirect dependencies #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
feat/indirect-packages
branch
from
80a9e1d to
39986b6
Compare
Fix the output of go mod directives from check-plugin command when operating with --format / -f flag. This now output go mod edit --replace directives for indirect dependencies which ensures that the versions are correctly pinned. Previously "fixes" were lost when go mod tidy was run. Fixes krakend#27
stevenh
force-pushed
the
feat/indirect-packages
branch
from
39986b6 to
e7565ae
Compare
|
The failure here is a false positive in the DeepSource tool as reported here: |
Apply a workaround for the false positive for GO-S2307.
|
Have added a workaround for the DeepSource false positive |
kpacha
approved these changes
Jul 15, 2024
|
@stevenh thanks for the contribution!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the output of go mod directives from check-plugin command when operating with --format / -f flag.
This now output go mod edit --replace directives for indirect dependencies which ensures that the versions are correctly pinned.
Previously "fixes" were lost when go mod tidy was run.
Fixes #27