remove defaults for extra_records

Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby · Dec 9, 2024 · d14810d · d14810d
1 parent e71c233
commit d14810d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/hscontrol/types/config.go b/hscontrol/types/config.go
@@ -261,8 +261,6 @@ func LoadConfig(path string, isFile bool) error {
 	viper.SetDefault("dns.nameservers.global", []string{})
 	viper.SetDefault("dns.nameservers.split", map[string]string{})
 	viper.SetDefault("dns.search_domains", []string{})
-	viper.SetDefault("dns.extra_records", []tailcfg.DNSRecord{})
-	viper.SetDefault("dns.extra_records_path", "")
 
 	viper.SetDefault("derp.server.enabled", false)
 	viper.SetDefault("derp.server.stun.enabled", true)

diff --git a/hscontrol/types/config_test.go b/hscontrol/types/config_test.go
@@ -280,9 +280,9 @@ func TestReadConfigFromEnv(t *testing.T) {
 						// "foo.bar.com": {"1.1.1.1"},
 					},
 				},
-				ExtraRecords: []tailcfg.DNSRecord{
-					// {Name: "prometheus.myvpn.example.com", Type: "A", Value: "100.64.0.4"},
-				},
+				// ExtraRecords: []tailcfg.DNSRecord{
+				// 	{Name: "prometheus.myvpn.example.com", Type: "A", Value: "100.64.0.4"},
+				// },
 				SearchDomains: []string{"test.com", "bar.com"},
 			},
 		},