Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added test for mergeDeletionCallBack #1125

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

satyazzz123
Copy link
Contributor

test for mergeDeletionCallBack

ii) test for scenario which checks for permissions of the destination directory to match the permissions of the source file when both the source file and destination directory exist

fixes a part of #881

Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the test label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa79dfa) 14.82% compared to head (96a8806) 14.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   14.82%   14.85%   +0.03%     
==========================================
  Files          90       90              
  Lines        8379     8379              
==========================================
+ Hits         1242     1245       +3     
+ Misses       6818     6813       -5     
- Partials      319      321       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyazzz123
Copy link
Contributor Author

@kmehant @seshapad please review this PR.

filesystem/merger_test.go Outdated Show resolved Hide resolved
filesystem/merger_test.go Outdated Show resolved Hide resolved
@satyazzz123
Copy link
Contributor Author

@HarikrishnanBalagopal I have addressed the requested changes . Please have a look . Thank you

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 3da8a07 into konveyor:main Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants