-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for TLS termination policies to OpenShift Routes #1089
feat: add support for TLS termination policies to OpenShift Routes #1089
Conversation
Signed-off-by: Soumil Paranjpay <[email protected]>
Thanks for making a pull request! 😃 |
Signed-off-by: Soumil Paranjpay <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
+ Coverage 14.79% 14.83% +0.04%
==========================================
Files 89 89
Lines 8275 8252 -23
==========================================
Hits 1224 1224
+ Misses 6732 6709 -23
Partials 319 319 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Soumil Paranjpay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Akash had suggested some changes and Soumil made those changes)
closes #972