Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TLS termination policies to OpenShift Routes #1089

Merged

Conversation

Soumil-07
Copy link
Contributor

closes #972

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (d05661f) 14.79% compared to head (5c0e779) 14.83%.

Files Patch % Lines
transformer/kubernetes/apiresource/service.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   14.79%   14.83%   +0.04%     
==========================================
  Files          89       89              
  Lines        8275     8252      -23     
==========================================
  Hits         1224     1224              
+ Misses       6732     6709      -23     
  Partials      319      319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Akash had suggested some changes and Soumil made those changes)

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 6b5badd into konveyor:main Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS route network passthrough
3 participants