Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate the enrollment details on launcher startup #2045
Generate the enrollment details on launcher startup #2045
Changes from 9 commits
5cb998c
1b258aa
9ac8a8b
ee1a0d8
f0a3c8a
25e9a93
a9b91ab
828f91e
872e0bf
c2bb734
2301f53
4041c4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can delay launcher startup for up to 30 seconds -- I think we probably don't want to do that. Maybe we should call
getEnrollmentDetails
in a goroutine so that it doesn't halt startup? (We would probably want to makeknapsack.enrollmentDetails
nullable --var enrollmentDetails *types.EnrollmentDetails
-- and then haveextension.Enroll
wait for those details to be available.)Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.