Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate __KOKKOSBATCHED_ENABLE_LAPACKE__ #2450

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion batched/KokkosBatched_Util.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,24 @@
#endif

#if defined(KOKKOSKERNELS_ENABLE_TPL_LAPACKE)
#define __KOKKOSBATCHED_ENABLE_LAPACKE__ 1
#define KOKKOSBATCHED_IMPL_ENABLE_LAPACKE 1
#if defined(KOKKOS_COMPILER_MSVC)
#define __KOKKOSBATCHED_ENABLE_LAPACKE__ \
( \
__pragma(message("warning: __KOKKOSBATCHED_ENABLE_LAPACKE__ is deprecated and will be " \
"removed in a future version")) KOKKOSBATCHED_IMPL_ENABLE_LAPACKE)
#elif defined(KOKKOS_COMPILER_GNU) || defined(KOKKOS_COMPILER_CLANG)
#define __KOKKOSBATCHED_ENABLE_LAPACKE__ \
(__extension__({ \
_Pragma( \
"\"__KOKKOSBATCHED_ENABLE_LAPACKE__ is deprecated and will be removed in a future " \
"version\""); \
KOKKOSBATCHED_IMPL_ENABLE_LAPACKE; \
}))
#else
#define __KOKKOSBATCHED_ENABLE_LAPACKE__ KOKKOSBATCHED_IMPL_ENABLE_LAPACKE // no good way to deprecate?
#endif

#include "lapacke.h"
#endif

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ struct SerialEigendecompositionInternal {
inline static int host_invoke(const int m, RealType* A, const int as0, const int as1, RealType* er, const int ers,
RealType* ei, const int eis, RealType* UL, const int uls0, const int uls1, RealType* UR,
const int urs0, const int urs1, RealType* w, const int wlen) {
#if defined(__KOKKOSBATCHED_ENABLE_LAPACKE__) || defined(KOKKOSBATCHED_IMPL_ENABLE_INTEL_MKL)
#if defined(KOKKOSBATCHED_IMPL_ENABLE_LAPACKE) || defined(KOKKOSBATCHED_IMPL_ENABLE_INTEL_MKL)
int matrix_layout(0), lda(0), uls(0), urs(0);
if (as0 == 1) {
assert(uls0 == 1 && "UL is not column major");
Expand Down
Loading