Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update comment #75

wants to merge 1 commit into from

Conversation

krishna116
Copy link

Hi kokke,
I have port this tiny-regex-c library to UEFI shell library and implement the regex tool using this library,
so I'd like to add a link in this readme.md to the UEFI shell version of this tiny-regex-c library, thank you!

@kokke
Copy link
Owner

kokke commented Dec 20, 2021

Hi @krishna116 and thank you for checking out the library :)

I don't currently link to other forks in the README, so I am not inclined to link to your fork either. Which changes did you make for your UEFI Shell-version?

@krishna116
Copy link
Author

It's no problem.

Which changes did you make for your UEFI Shell-version?
The EDK2 doesn't have standard c libraries such as stdio.h and ctype.h, so I used custom defines here:
https://github.com/krishna116/UefiTest/tree/master/KrishnaTestPkg/Application/regex/crt

Nothing need to change tiny-regex-c's code, I just wrap tiny-regex-c's API to UEFI-style-API here:
https://github.com/krishna116/UefiTest/blob/master/KrishnaTestPkg/Application/regex/TinyRegexLib.h
https://github.com/krishna116/UefiTest/blob/master/KrishnaTestPkg/Application/regex/TinyRegexLib.c

That's all, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants