Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero string output #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Zero string output #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7931651
Modified zero string output
HYUNSEONG-KIM Aug 12, 2024
b631a40
Update bn.c
HYUNSEONG-KIM Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions bn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,22 @@ void bignum_to_string(struct bn* n, char* str, int nbytes)
j += 1;
}

/* Move string j places ahead, effectively skipping leading zeros */
for (i = 0; i < (nbytes - j); ++i)
/* Detect whether bignum is zero or not */
if (j == 2*BIG_NUM_BYTES)
{
str[i] = str[i + j];
str[0] = '0';
str[1] = 0;
}
else
{
/* Move string j places ahead, effectively skipping leading zeros */
for (i = 0; i < (nbytes - j); ++i)
{
str[i] = str[i + j];
}
/* Zero-terminate string */
str[i] = 0;
}

/* Zero-terminate string */
str[i] = 0;
}


Expand Down
6 changes: 5 additions & 1 deletion bn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ There may well be room for performance-optimizations and improvements.
#define WORD_SIZE 4
#endif

#ifndef BIG_NUM_BYTES
#define BIG_NUM_BYTES 128
#endif

/* Size of big-numbers in bytes */
#define BN_ARRAY_SIZE (128 / WORD_SIZE)
#define BN_ARRAY_SIZE (BIG_NUM_BYTES / WORD_SIZE)


/* Here comes the compile-time specialization for how large the underlying array size should be. */
Expand Down