Fix: Protocol support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support protocols
expand scope of test by also testing protocols
upgrade action version and expand python check support
drop 3.11 and 3.12 support
update dependencies and address typing
add missing httpx package
arranged typing and removed outdated pytest arg
reinclude support for python 3.11 and 3.12 tests
Support protocols
|
@dkraczkowski ping in case notifications for this were lost. Thanks for your time. |
barraponto
suggested changes
Mar 26, 2024
drop support for python 3.7 Co-authored-by: Capi Etheriel <[email protected]>
|
@jarey I just wanted to take a moment to extend my heartfelt thanks for your contribution. Your support and effort truly made my day much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour
Kink current implementation fails to process classes that implement a Protocol. When a Protocol is implemented kink raises an incorrect exception about args/kwargs not matching expected ones.
Expected behaviour
Kink supports Protocols as part of the class hierarchy/interface implementation, processing dependency injection in the right way even if such elements are included as part of the class hierarchy.
Content of this PR