fix: support OFF for SystemStatus #168

kodebach · Jan 6, 2025 · bca4159 · bca4159
1 parent caac038
commit bca4159
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/custom_components/idm_heatpump/const.py b/custom_components/idm_heatpump/const.py
@@ -117,6 +117,7 @@ def _missing_(cls, value) -> Any:
 class SystemStatus(_SensorEnum):
     """IDM heat pump system status."""
 
+    OFF = 0xFFFF
     STANDBY = 0
     AUTOMATIC = 1
     AWAY = 2

diff --git a/custom_components/idm_heatpump/sensor_addresses.py b/custom_components/idm_heatpump/sensor_addresses.py
@@ -298,7 +298,8 @@ def datatype(self) -> ModbusClientMixin.DATATYPE:
     def decode(self, registers: list[int]) -> tuple[bool, _EnumT]:
         value = self._decode_raw(registers)
         LOGGER.debug("raw value (uint16) for %s: %d", self.name, value)
-        if value == 0xFFFF:
+
+        if value == 0xFFFF and 0xFFFF not in list(map(int, self.enum)):
             # special case: unavailable
             return (False, self.enum(None))
 

diff --git a/custom_components/idm_heatpump/services.yaml b/custom_components/idm_heatpump/services.yaml
@@ -171,6 +171,7 @@ set_system_status:
       selector:
         select:
           options:
+            - off
             - standby
             - automatic
             - away

diff --git a/custom_components/idm_heatpump/translations/de.json b/custom_components/idm_heatpump/translations/de.json
@@ -268,6 +268,7 @@
         },
         "system_status_options": {
             "options": {
+                "off": "Komplett Aus (kein Frostschutz)",
                 "standby": "Standby",
                 "automatic": "Automatik",
                 "away": "Abwesend",

diff --git a/custom_components/idm_heatpump/translations/en.json b/custom_components/idm_heatpump/translations/en.json
@@ -268,6 +268,7 @@
         },
         "system_status_options": {
             "options": {
+                "off": "Off (no freeze protection)",
                 "standby": "Standby",
                 "automatic": "Automatic",
                 "away": "Away",
-Original file line number
+Diff line change
@@ Expand Up / @@ -171,6 +171,7 @@ set_system_status: @@
           selector:
             select:
               options:
+                - off
                 - standby
                 - automatic
                 - away
@@ Expand Down @@