Restrict anonymous submission migration to surveys #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset types other than `survey` should not be assigned `add_submissions`; we thought it was benign, but it can cause problems when: 1. The back end includes this in the list of permissions assignments served to the front end for some non-`survey` library item 2. The front end sends the (possibly modified) assignments back in bulk, including the extraneous `add_submission` assignment 3. The back end rejects the front end's request because `add_submission` is not a valid assignment for the asset type
noliveleger
approved these changes
Feb 9, 2024
noliveleger
deleted the
restrict-anonymous-submission-migration-to-surveys
branch
|
We should add a note to release notes to self-hosters how to remove the permissions on other asset types. |
|
Let's go one further and make another migration that removes them. I'll open a PR for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Asset types other than
surveyshould not be assignedadd_submissions; we thought it was benign, but it can cause problems when:surveylibrary itemadd_submissionassignmentadd_submissionis not a valid assignment for the asset typeInternal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/can't.20share.20collections.20in.20library/near/337874
Description
Avoids future "Failed to update permissions" errors when trying to change sharing settings for library items
Related issues
Related to #4719