New futures #15
Open
New futures #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
hey is there anything left to do in order to merge this? |
|
@agrinman oh, I almost forgot about this PR. I sort of turned my focus towards #14 (rebase of #12) which is focused on the edition change. Therefore I kind of planned for #14 to be merged first and then deal with the conflicts in this PR. However, if someone wants this to be merged first/instead of #14 then I'll be happy to try to make sure this PR ready. As far as I can remember it should already be ready, however I should probably have an extra look. |
That'd be nice! I'm on day two of learning Rust, thought I'd have a go at pinging something, and this threw me for a bit of a loop 😅 Appreciate your efforts regardless, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have converted from 0.1 futures and tokio 0.1 to std futures with async await and tokio 0.2. However to use async/await I had to convert to the 2018 edition which probably is done better in #12