Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import & Export directives #415

Merged
merged 43 commits into from
Nov 20, 2023
Merged

Import & Export directives #415

merged 43 commits into from
Nov 20, 2023

Conversation

mmarx
Copy link
Member

@mmarx mmarx commented Nov 17, 2023 •
edited
Loading

@mmarx mmarx added enhancement New feature or request Parser Rule-Parser-Related Issue CSV CSV-Related Issue logical logical layer io api public crate API rdf RDF support labels Nov 17, 2023
@mmarx mmarx added this to the Release 0.4.0 milestone Nov 17, 2023
@mmarx mmarx self-assigned this Nov 17, 2023
@mmarx mmarx force-pushed the feature/293-import-export branch from 2f0528d to cc298e7 Compare November 18, 2023 02:37
mmarx added 17 commits November 18, 2023 03:38
@mmarx mmarx force-pushed the feature/293-import-export branch from cc298e7 to 7f57ff9 Compare November 18, 2023 02:53
mmarx added 3 commits November 19, 2023 04:36
@mmarx
Rename RDFTriplesReader to RDFReader
009b690
@mmarx
flake.lock: Update
554e46f 
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/d4b5a67bbe9ef750bd2fdffd4cad400dd5553af8' (2023-11-14)
  → 'github:NixOS/nixpkgs/9fb122519e9cd465d532f736a98c1e1eb541ef6f' (2023-11-16)
• Updated input 'nixpkgs-unstable':
    'github:NixOS/nixpkgs/e44462d6021bfe23dfb24b775cc7c390844f773d' (2023-11-12)
  → 'github:NixOS/nixpkgs/c757e9bd77b16ca2e03c89bf8bc9ecb28e0c06ad' (2023-11-17)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/e485313fc485700a9f1f9b8b272ddc0621d08357' (2023-11-14)
  → 'github:oxalica/rust-overlay/45066cb0b2505d8da581be8432a16238c867f199' (2023-11-19)
@mmarx
Update dependencies
db08b96
@mmarx mmarx marked this pull request as ready for review November 19, 2023 04:08
monsterkrampe
monsterkrampe previously requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@monsterkrampe monsterkrampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I'm only wondering about the removed tests; apart from that this can be merged imo :)

nemo/src/program_analysis/type_inference.rs Outdated Show resolved Hide resolved
matzemathics
matzemathics requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@matzemathics matzemathics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some nice improvements. I have some ideas for readability and some questions

nemo/src/io/formats/types.rs Outdated Show resolved Hide resolved
nemo/src/io/formats/types.rs Show resolved Hide resolved
nemo/src/io/formats/rdf.rs
})
}

/// Obtain an [ImportSpec] for this format.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for backwards compatibility only, right? Maybe add a comment explaining that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it just be for backwards compatibility? This is how you would create an ImportSpec without involving the parser.

nemo/src/io/formats/rdf.rs Outdated Show resolved Hide resolved
nemo-cli/src/main.rs Show resolved Hide resolved
nemo/src/model/rule_model/map.rs Outdated Show resolved Hide resolved
matzemathics
matzemathics reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@matzemathics matzemathics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some nice improvements. I have some ideas for readability and some questions

@mmarx mmarx dismissed monsterkrampe’s stale review November 20, 2023 18:11

Requested changes were implemented

@mmarx mmarx merged commit ca1beee into main Nov 20, 2023
8 checks passed
@mmarx mmarx deleted the feature/293-import-export branch November 20, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlwww rlwww rlwww approved these changes

@matzemathics matzemathics matzemathics approved these changes

@monsterkrampe monsterkrampe Awaiting requested review from monsterkrampe

Assignees

@mmarx mmarx

Labels
api public crate API CSV CSV-Related Issue enhancement New feature or request io logical logical layer Parser Rule-Parser-Related Issue rdf RDF support
Projects
nemo
Archived in project
Milestone
Release 0.4.0
4 participants
@mmarx @monsterkrampe @matzemathics @rlwww