Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support wildcard terms #409

Merged
merged 4 commits into from
Nov 9, 2023
Merged

support wildcard terms #409

merged 4 commits into from
Nov 9, 2023

Conversation

matzemathics
Copy link
Collaborator

No description provided.

@matzemathics matzemathics linked an issue Nov 9, 2023 that may be closed by this pull request
writing wildcard instead of a variable name #408
Closed
@matzemathics matzemathics added enhancement New feature or request Parser Rule-Parser-Related Issue labels Nov 9, 2023
@matzemathics matzemathics requested a review from mmarx November 9, 2023 14:47
@mmarx
Copy link
Member

mmarx commented Nov 9, 2023

Instead of getting an error about unsafe rules, we should have an explicit check and a more helpful error message for wildcards used in rule heads.

mmarx
mmarx requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@mmarx mmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented already, this still needs a helpful error message. Looks good otherwise!

@matzemathics matzemathics merged commit 4a563b3 into main Nov 9, 2023
8 checks passed
@matzemathics matzemathics deleted the wildcard-terms branch November 14, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarx mmarx mmarx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Parser Rule-Parser-Related Issue
Projects
nemo
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

writing wildcard instead of a variable name
2 participants
@matzemathics @mmarx