Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: using u64 instead of usize in hashmap dictionary #401

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

larry-gonzalez
Copy link
Collaborator

The recently introduced hashmap dictionary defines and uses some usize constants that break the wasm build because in such architecture, usize is 32 bits long instead of 64.

In this pull request, we tackle such problem by using constants of type u64 instead of usize.

@mmarx mmarx added bug Something isn't working wasm issue related to compiling for the Web Assembly target labels Nov 7, 2023
@mmarx mmarx added this to the Release 0.4.0 milestone Nov 7, 2023
@mmarx mmarx merged commit 506aeba into main Nov 7, 2023
7 checks passed
@mmarx mmarx deleted the u64-for-wasm branch November 7, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wasm issue related to compiling for the Web Assembly target
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants