Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 401 to the explicitly defined codes #114

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

xiangpingjiang
Copy link
Contributor

Changes

/kind

Fixes #108

Release Note


Docs

Add 401 to the explicitly defined codes

Copy link

knative-prow bot commented Jan 12, 2024

@xiangpingjiang: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #108

Release Note


Docs

Add 401 to the explicitly defined codes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from davidhadas and nainaz January 12, 2024 06:50
Copy link

knative-prow bot commented Jan 12, 2024

Welcome @xiangpingjiang! It looks like this is your first PR to knative/specs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2024
Co-authored-by: Christoph Stäbler <[email protected]>
@ReToCode
Copy link
Member

PTAL @knative/steering-committee, @knative/technical-oversight-committee

@creydr
Copy link
Member

creydr commented Jan 25, 2024

@aliok @dsimansk could you PTAL at this?

/assign @aliok @dsimansk

@dprotaso
Copy link
Member

/assign @pierDipi

@creydr
Copy link
Member

creydr commented Feb 1, 2024

@pierDipi could you PTAL?

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@pierDipi
Copy link
Member

pierDipi commented Feb 1, 2024

I have no power to approve here :)

@psschwei
Copy link
Contributor

psschwei commented Feb 1, 2024

I'm assuming based on the discussion in knative/community#1399 that @knative/technical-oversight-committee owns changes to the spec now.

And we probably should vote on spec changes... we can probably do that async, but I'll add it to the TOC backlog too just in case.

+1 from me

@dprotaso
Copy link
Member

+1 from me

@dsimansk
Copy link

+1

@dprotaso
Copy link
Member

/approve

Copy link

knative-prow bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@knative-prow knative-prow bot merged commit b2d3a79 into knative:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Adding 401 to the explicitly defined codes
8 participants