JobSink with Istio config for Job spec #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
the
size/S
pierDipi
reviewed
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8430 +/- ##
=======================================
Coverage 64.10% 64.10%
=======================================
Files 388 388
Lines 23363 23363
=======================================
Hits 14976 14976
Misses 7591 7591
Partials 796 796 ☔ View full report in Codecov by Sentry. |
mgencur
force-pushed
the
job_sink_pod_with_istio_main
branch
from
617b362 to
2feaf19
Compare
mgencur
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for correct functioning of the test with Istio.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs