WIP: Integration of certmanager for IntegrationSink #8385
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,13 @@ kube::codegen::gen_client \ | |
| --with-watch \ | ||
| "${REPO_ROOT_DIR}/pkg/apis" | ||
|
|
||
| kube::codegen::gen_client \ | ||
|
There was a problem hiding this comment. @matzew You can clean up this as in https://github.com/knative/serving/pull/15703/files#diff-149dfe7bb29d1191dceae3a52915e750e64b7f87257a5fb309c29d3056e2a95d. We are removing the generated clientsets in favor of the original ones |
||
| --boilerplate "${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt" \ | ||
| --output-dir "${REPO_ROOT_DIR}/pkg/client/certmanager" \ | ||
| --output-pkg "knative.dev/eventing/pkg/client/certmanager" \ | ||
| --with-watch \ | ||
| "${REPO_ROOT_DIR}/vendor/github.com/cert-manager/cert-manager/pkg/apis" | ||
|
|
||
| group "Knative Codegen" | ||
|
|
||
| # Knative Injection | ||
|
|
@@ -52,6 +59,13 @@ ${KNATIVE_CODEGEN_PKG}/hack/generate-knative.sh "injection" \ | |
| "sinks:v1alpha1 eventing:v1alpha1 eventing:v1beta1 eventing:v1beta2 eventing:v1beta3 eventing:v1 messaging:v1 flows:v1 sources:v1alpha1 sources:v1beta2 sources:v1 duck:v1beta1 duck:v1" \ | ||
| --go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt | ||
|
|
||
| # Knative Injection (for cert-manager) | ||
| ${KNATIVE_CODEGEN_PKG}/hack/generate-knative.sh "injection" \ | ||
| knative.dev/eventing/pkg/client/certmanager github.com/cert-manager/cert-manager/pkg/apis \ | ||
| "certmanager:v1 acme:v1" \ | ||
| --disable-informer-init \ | ||
| --go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt | ||
|
|
||
| group "Generating API reference docs" | ||
|
|
||
| ${REPO_ROOT_DIR}/hack/update-reference-docs.sh | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this does not work, when changing the
featurecfg afterwards. In thecontroller.goof the integrationsink I am getting anilpointer... when accessing thecmCertificateListerthere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't, we could start / stop the informer manually without injection based on the value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean the "cert manager" informers, right? start / stop based on cfg change of the
config-featureCM?Any pointer to similar code for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we start a "custom" configmap informer using the factory
eventing/pkg/adapter/v2/main.go
Lines 227 to 250 in b00da59
the "stop" is based on the passed context and there we can use the usual "context / cancel" pair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of background info. We discussed a more dynamic approach in the past here. Serving requires for the controller pod to be restarted. In general making it dynamic here makes more sense as it reacts on some cm change and you can freely define your main stuff as in the adapter's main. For Serving once you disable encryption there will be downtime afaik and we wanted minimal changes back then to move with the internal encryption feature. cc @ReToCode if he has anything to add/correct me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skonto so you suggest going the route via knative/pkg#2989 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the UX. If you dont want a pod restart you need the dynamic informer addition/removal. The flag just avoids generating by default the init code that registers an informer factory and the related informer. We don't want to register that immediately because the feature might be disabled. We cant do this dynamically without a restart because registration does not start the informer we have to wait for sharedmain to do this. So right now once sharedmain does start the controllers and the informers you can't start a new one but potentially we could extend sharedmain to do this.