Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add triggers OIDC identity to Reply & DLS requests #7481

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add triggers OIDC identity to Reply & DLS requests #7481

merged 1 commit into from
Dec 4, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Nov 29, 2023 •
edited
Loading

Fixes #7480

Proposed Changes

  • 🎁 Use triggers OIDC identity in Reply & DLS requests
  • Route mt-brokers Reply & DLS requests via the broker-filter, as this has the trigger object to get the used OIDC identity

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release labels Nov 29, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 29, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (79bb385) 76.63% compared to head (8edc6ba) 76.35%.

❗ Current head 8edc6ba differs from pull request most recent head 5ac84a3. Consider uploading reports for the commit 5ac84a3 to get more accurate results

Files Patch % Lines
pkg/broker/filter/filter_handler.go 36.27% 61 Missing and 4 partials ⚠️
pkg/apis/duck/v1/delivery_types.go 0.00% 6 Missing ⚠️
pkg/reconciler/sugar/trigger/path/path.go 33.33% 5 Missing and 1 partial ⚠️
pkg/reconciler/broker/broker.go 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7481      +/-   ##
==========================================
- Coverage   76.63%   76.35%   -0.28%     
==========================================
  Files         259      260       +1     
  Lines       14270    14402     +132     
==========================================
+ Hits        10936    10997      +61     
- Misses       2778     2844      +66     
- Partials      556      561       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@creydr creydr force-pushed the mt-broker-reply-and-dls-via-broker-filter branch from 03e27be to 6b5aa04 Compare November 30, 2023 10:23
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2023
@creydr creydr force-pushed the mt-broker-reply-and-dls-via-broker-filter branch from 6b5aa04 to 1a1addd Compare November 30, 2023 14:26
@creydr creydr changed the title [WIP] Add triggers OIDC identity to Reply & DLS requests Add triggers OIDC identity to Reply & DLS requests Dec 1, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@creydr
Copy link
Member Author

creydr commented Dec 1, 2023

@pierDipi I think this is ready for review
/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi December 1, 2023 09:47
pierDipi
pierDipi reviewed Dec 4, 2023
View reviewed changes
pkg/reconciler/broker/trigger/trigger.go Outdated Show resolved Hide resolved
pkg/reconciler/broker/trigger/trigger.go Outdated Show resolved Hide resolved
@pierDipi
Copy link
Member

pierDipi commented Dec 4, 2023

2 minor comments

/approve

@creydr creydr requested a review from pierDipi December 4, 2023 10:37
@creydr
Add triggers OIDC identity to Reply & DLS requests
5ac84a3 
Fix boilerplate header

Add metrics to reply & DLS requests and refactor

Add e2e test

Fix broker to setup its own delivery status

Fix trigger reconciler to not update broker spec

Add reply test

Address review comments
@creydr creydr force-pushed the mt-broker-reply-and-dls-via-broker-filter branch from 8edc6ba to 5ac84a3 Compare December 4, 2023 13:57
@creydr
Copy link
Member Author

creydr commented Dec 4, 2023

rebased.
@pierDipi could you recheck?

pierDipi
pierDipi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6abe85b into knative:main Dec 4, 2023
33 checks passed
@creydr creydr linked an issue Dec 20, 2023 that may be closed by this pull request
Add OIDC e2e test mt-broker #7458
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add triggers OIDC identity to Reply & DLS requests Add OIDC e2e test mt-broker
3 participants
@creydr @pierDipi @knative-prow-robot